[webkit-reviews] review granted: [Bug 123408] Clean up ScopedEventQueue : [Attachment 215316] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 28 10:10:10 PDT 2013


Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 123408: Clean up ScopedEventQueue
https://bugs.webkit.org/show_bug.cgi?id=123408

Attachment 215316: Patch
https://bugs.webkit.org/attachment.cgi?id=215316&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215316&action=review


> Source/WebCore/dom/ScopedEventQueue.cpp:77
> +    Vector<RefPtr<Event>> queuedEvents;
> +    queuedEvents.swap(m_queuedEvents);

We should use move instead of swap here:

    Vector<RefPtr<Event>> queuedEvents = std::move(m_queuedEvents);


More information about the webkit-reviews mailing list