[webkit-reviews] review denied: [Bug 123397] [CoordinatedGraphics] ASSERTION FAILED: !m_flushingLayers in several tests : [Attachment 215272] RFC patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Sergio Correia
<sergio.correia at openbossa.org>'s request for review:
Bug 123397: [CoordinatedGraphics] ASSERTION FAILED: !m_flushingLayers in
several tests
https://bugs.webkit.org/show_bug.cgi?id=123397

Attachment 215272: RFC patch
https://bugs.webkit.org/attachment.cgi?id=215272&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215272&action=review


> Source/WebCore/ChangeLog:11
> +	   flushCompositingState(), but in some code paths we don't go through
it
> +	   and end up calling scheduleLayerFlush() when we shouldn't.

What code paths? Seems like this patch works around a problem which we need to
understand better.

>
Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
93
> +    startedFlushingLayerChanges();

willFlushLayerChanges

>
Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
122
> +    finishedFlushingLayerChanges();

didFlushLayerChanges