[webkit-reviews] review requested: [Bug 123375] WebIconDatabase can miss private browsing state changes : [Attachment 215264] Patch v2 - Add a necessary null check, more comprehensively set the private browsing value at icon database creation time.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 26 18:24:20 PDT 2013


Brady Eidson <beidson at apple.com> has asked  for review:
Bug 123375: WebIconDatabase can miss private browsing state changes
https://bugs.webkit.org/show_bug.cgi?id=123375

Attachment 215264: Patch v2 - Add a necessary null check, more comprehensively
set the private browsing value at icon database creation time.
https://bugs.webkit.org/attachment.cgi?id=215264&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
This patch fixes the crash, and is better at the time of icon database
creation.

I'm not sure why Alexey states that a WebContext notification for
starting/stopping private browsing isn't a good place to do private browsing
maintenance for WebContext-owned objects, but hopefully he can explain along
with a review!	:)


More information about the webkit-reviews mailing list