[webkit-reviews] review granted: [Bug 123356] Web Inspector: Change how the load and content ready event timestamps are tracked. : [Attachment 215207] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 25 15:34:43 PDT 2013
Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 123356: Web Inspector: Change how the load and content ready event
timestamps are tracked.
https://bugs.webkit.org/show_bug.cgi?id=123356
Attachment 215207: Patch
https://bugs.webkit.org/attachment.cgi?id=215207&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215207&action=review
r=me
> Source/WebInspectorUI/UserInterface/TimelineManager.js:-61
> - return this._loadEventTime;
You are removing this._loadEventTime, you can remove this instance variable
from:
1. The constructor
2. _clear
3. Replace the use in _addRecord to look at the MainFrame
On IRC you've handled these.
More information about the webkit-reviews
mailing list