[webkit-reviews] review granted: [Bug 123341] Improve JSC Parser error messages : [Attachment 215184] Appease efl build

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 123341: Improve JSC Parser error messages
https://bugs.webkit.org/show_bug.cgi?id=123341

Attachment 215184: Appease efl build
https://bugs.webkit.org/attachment.cgi?id=215184&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215184&action=review


r=me, assuming ews digs it.

> Source/JavaScriptCore/parser/Parser.cpp:107
> +    , m_lastFunctionName(0)

nullptr

> Source/JavaScriptCore/parser/Parser.cpp:1045
> +    return 0;

nullptr

> Source/JavaScriptCore/parser/Parser.cpp:1055
> +    m_lastFunctionName = 0;

nullptr

> Source/JavaScriptCore/parser/Parser.cpp:2014
> +    ASSERT_NOT_REACHED();
> +    return "error";

Why not just RELEASE_ASSERT_NOT_REACHED here?