[webkit-reviews] review denied: [Bug 123260] Replace 0 timeouts g_timeout_add() by g_idle_add() : [Attachment 215146] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 123260: Replace 0 timeouts g_timeout_add() by g_idle_add()
https://bugs.webkit.org/show_bug.cgi?id=123260

Attachment 215146: Patch
https://bugs.webkit.org/attachment.cgi?id=215146&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215146&action=review


> Source/WebCore/ChangeLog:11
> +	   Patch by Bastien Nocera <hadess at hadess.net>

Why not adding the author to the changelog header so that commit-queue will
credit him correctly?

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5276
> -	   g_timeout_add(1, cleanupTemporarilyCachedSubresources,
g_list_copy(subResources));
> +	   g_idle_add_full(G_PRIORITY_DEFAULT,
cleanupTemporarilyCachedSubresources, g_list_copy(subResources), 0);

This is not correct, I don't know why but this was not a 0 timeout.