[webkit-reviews] review granted: [Bug 123302] Get rid of InlineStart so that I don't have to implement it in FTL : [Attachment 215127] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 24 20:39:52 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 123302: Get rid of InlineStart so that I don't have to implement it in FTL
https://bugs.webkit.org/show_bug.cgi?id=123302

Attachment 215127: the patch
https://bugs.webkit.org/attachment.cgi?id=215127&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215127&action=review


r=me

> Source/JavaScriptCore/ftl/FTLLink.cpp:61
> +	   state.jitCode->common.inlineCallFrames =
state.graph.m_inlineCallFrames.release();

I believe std::move() (rather than release()) is the preferred way to do this
these days.


More information about the webkit-reviews mailing list