[webkit-reviews] review granted: [Bug 123294] Uncomplicate some of SVGTextRunRenderingContext. : [Attachment 215112] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 123294: Uncomplicate some of SVGTextRunRenderingContext.
https://bugs.webkit.org/show_bug.cgi?id=123294

Attachment 215112: Patch
https://bugs.webkit.org/attachment.cgi?id=215112&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=215112&action=review


> Source/WebCore/ChangeLog:10
> +	   - Constructor now takes a RenderObject&.

RenderObject :(

> Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:56
> -static inline RenderObject* firstParentRendererForNonTextNode(RenderObject*
renderer)
> +static inline RenderElement& firstParentRendererForNonTextNode(RenderObject&
renderer)

The name is totally misleading.

> Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:59
> +    if (renderer.isText()) {
> +	   ASSERT(renderer.parent());

Text renderers always have parent. The assert doesn't add anything.