[webkit-reviews] review granted: [Bug 107301] methods on window.internals shouldn't pass in a document : [Attachment 215084] Proposed patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Afonso Costa
<afonso.costa at samsung.com>'s request for review:
Bug 107301: methods on window.internals shouldn't pass in a document
https://bugs.webkit.org/show_bug.cgi?id=107301

Attachment 215084: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=215084&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215084&action=review


> Source/WebCore/ChangeLog:11
> +	   Each 'Internals' instance is associated with a 'Document'. So, it
> +	   is not necessary to pass a document as argument. Only nodesFromRect
and
> +	   layerTreeAsText methods were kept because, in some Layout Tests, the

> +	   'Document' object is not the same used by
Internals::contextDocument.

Can you add comments in these functions explaining why they take the document
argument?

> Source/WebCore/ChangeLog:13
> +	   No new tests.

No reason to add this line, it's pretty obvious to anyone who would care why
there are no new tests.