[webkit-reviews] review granted: [Bug 123281] Web Inspector: Adjust the precision of byte strings : [Attachment 215087] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 24 11:53:21 PDT 2013


Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 123281: Web Inspector: Adjust the precision of byte strings
https://bugs.webkit.org/show_bug.cgi?id=123281

Attachment 215087: Patch
https://bugs.webkit.org/attachment.cgi?id=215087&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215087&action=review


> Source/WebInspectorUI/UserInterface/Utilities.js:942
> +	   else if (higherResolution && kilobytes < 1024)
> +	       return WebInspector.UIString("%.1f KB").format(kilobytes);

This should be just "kilobytes < 1024", if higherResolution  were true, the top
if would have been taken.


More information about the webkit-reviews mailing list