[webkit-reviews] review granted: [Bug 123231] Web Inspector: Breakpoints in sourceURL named scripts do not work : [Attachment 215081] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 123231: Web Inspector: Breakpoints in sourceURL named scripts do not work
https://bugs.webkit.org/show_bug.cgi?id=123231

Attachment 215081: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=215081&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215081&action=review


> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:714
> +    String scriptURL = hasSourceURL ? script.sourceURL : script.url;

I wonder if we should just have one property — script.url — for the URL. Are
both useful? Are other places that need to do something similar?