[webkit-reviews] review granted: [Bug 123273] Stop bringing in the std namespace : [Attachment 215069] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 123273: Stop bringing in the std namespace
https://bugs.webkit.org/show_bug.cgi?id=123273

Attachment 215069: Patch
https://bugs.webkit.org/attachment.cgi?id=215069&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215069&action=review


> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:160
> -    when = max(0.0, when);
> +    when = std::max<double>(0, when);

Inconsistent that you did this here, but not in DelayDSPKernel.cpp.

> Source/WebCore/rendering/LineWidth.cpp:190
> -	   newLineWidth = max(0.0f, newLineRight - newLineLeft);
> +	   newLineWidth = std::max(0.0f, newLineRight - newLineLeft);

Later in the same file you did this the other way (max<float>).