[webkit-reviews] review denied: [Bug 123260] Replace 0 timeouts g_timeout_add() by g_idle_add() : [Attachment 215047] Replace 0 timeouts g_timeout_add() by g_idle_add()

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Bastien Nocera
<hadess at hadess.net>'s request for review:
Bug 123260: Replace 0 timeouts g_timeout_add() by g_idle_add()
https://bugs.webkit.org/show_bug.cgi?id=123260

Attachment 215047: Replace 0 timeouts g_timeout_add() by g_idle_add()
https://bugs.webkit.org/attachment.cgi?id=215047&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215047&action=review


Patch looks good but needs a ChangeLog with the rationale.

>> Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp:94
>> +						      
const_cast<void*>(static_cast<const void*>(this)), 0);
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]

I know you're just matching what was here before, but the entire function call
should be on a single line.