[webkit-reviews] review denied: [Bug 123170] Keyframe animations do multiple style recalcs before starting : [Attachment 215010] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 23 23:36:34 PDT 2013


Darin Adler <darin at apple.com> has denied Ralph T <ralpht+bugs at gmail.com>'s
request for review:
Bug 123170: Keyframe animations do multiple style recalcs before starting
https://bugs.webkit.org/show_bug.cgi?id=123170

Attachment 215010: Patch
https://bugs.webkit.org/attachment.cgi?id=215010&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215010&action=review


Looks like a good change to me.

> Source/WebCore/ChangeLog:13
> +	   No new tests (OOPS!).

Is a test possible? If not, please replace this with an explanation of why not.
If a test is possible, please include it in the patch.

Can’t land a patch with this OOPS in it; the Subversion pre-commit hook will
reject it.

> Source/WebCore/page/animation/KeyframeAnimation.cpp:39
> +#include "RenderLayer.h"
> +#include "RenderLayerCompositor.h"

Should not add these includes.


More information about the webkit-reviews mailing list