[webkit-reviews] review granted: [Bug 123216] Add CryptoKey base class and bindings : [Attachment 214997] with release build fix

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 123216: Add CryptoKey base class and bindings
https://bugs.webkit.org/show_bug.cgi?id=123216

Attachment 214997: with release build fix
https://bugs.webkit.org/attachment.cgi?id=214997&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214997&action=review


r=me

> Source/WebCore/bindings/js/JSCryptoAlgorithmBuilder.h:49
> +    JSC::ExecState* m_exec;

It might be slightly more efficient to store a VM& here.  I think everything
except perhaps constructEmptyObject has an override that takes a VM& or VM*.

> Source/WebCore/bindings/js/JSCryptoAlgorithmBuilder.h:50
> +    JSC::Strong<JSC::JSObject> m_dictionary;

If this is only ever used on the stack, does this have to be a Strong?