[webkit-reviews] review granted: [Bug 123223] Web Inspector: Add a way to test the Manager and model classes : [Attachment 215009] Patch V2

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 123223: Web Inspector: Add a way to test the Manager and model classes
https://bugs.webkit.org/show_bug.cgi?id=123223

Attachment 215009: Patch V2
https://bugs.webkit.org/attachment.cgi?id=215009&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215009&action=review


> LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js:157
> +    InspectorBackend.registerPageDispatcher(new WebInspector.PageObserver);
> +    InspectorBackend.registerDOMDispatcher(new WebInspector.DOMObserver);
> +
> +    WebInspector.frameResourceManager = new
WebInspector.FrameResourceManager;
> +    WebInspector.domTreeManager = new WebInspector.DOMTreeManager;
> +
> +    InspectorFrontendHost.loaded();

This will need to mimic the code in Main.js. Either we should share it or at
the very least add a comment to keep it in sync.

> Source/WebInspectorUI/UserInterface/URLUtilities.js:177
> +WebInspector.displayNameForURL = function(url, urlComponents)

It is tempting to remove the namespace here too to match the other functions
now.

> Source/WebInspectorUI/UserInterface/URLUtilities.js:192
> +WebInspector.displayNameForHost = function(host)

Ditto.