[webkit-reviews] review granted: [Bug 123206] Build scripts should add |Win32 for Windows 32-bit builds : [Attachment 214986] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 123206: Build scripts should add |Win32 for Windows 32-bit builds
https://bugs.webkit.org/show_bug.cgi?id=123206

Attachment 214986: Patch
https://bugs.webkit.org/attachment.cgi?id=214986&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214986&action=review


r=me

> Tools/Scripts/old-run-webkit-tests:436
> +    $dumpToolName .= "_debug" if configuration() eq "Debug_All";

I think this is now called "DebugSuffix" in the Visual Studio project, but I'm
not sure if other targets use "Debug_All" to define their builds.

We might want to change this to "DebugSuffix" if it's only used on Windows.