[webkit-reviews] review denied: [Bug 123144] [GTK] enable media-stream in build-webkit : [Attachment 214826] enable mediastream in autofools

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 123144: [GTK] enable media-stream in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=123144

Attachment 214826: enable mediastream in autofools
https://bugs.webkit.org/attachment.cgi?id=214826&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214826&action=review


I'm okay with enabling media stream for build-webkit, but let's not add a
configure flag.

> Source/autotools/ReadCommandLineArguments.m4:133
> +AC_MSG_CHECKING([whether to enable media stream support])
> +AC_ARG_ENABLE(media_stream, 
> +    AC_HELP_STRING([--enable-media-stream], [enable media stream support
(incomplete) [default=no]]),
> +    [],
> +    [enable_media_stream="no"])
> +AC_MSG_RESULT([$enable_media_stream])
> +

I don't think we actually need a configuration flag for this. It's incomplete
and we don't typically add flags for web features. The existing flags are
exceptions to this rule.