[webkit-reviews] review granted: [Bug 123203] Make more StringImpl construction functions return PassRef. : [Attachment 214950] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 23 06:41:44 PDT 2013


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 123203: Make more StringImpl construction functions return PassRef.
https://bugs.webkit.org/show_bug.cgi?id=123203

Attachment 214950: Patch
https://bugs.webkit.org/attachment.cgi?id=214950&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=214950&action=review


> Source/WTF/wtf/text/AtomicString.cpp:134
>      static void translate(StringImpl*& location, const UCharBuffer& buf,
unsigned hash)

Can these just return PassRef<StringImpl>?


More information about the webkit-reviews mailing list