[webkit-reviews] review denied: [Bug 118759] [EFL] Calling ewk_settings_application_cache_path_set() more than once should have no effect. : [Attachment 206877] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Donggwan Kim
<donggwan.kim at samsung.com>'s request for review:
Bug 118759: [EFL] Calling ewk_settings_application_cache_path_set() more than
once should have no effect.
https://bugs.webkit.org/show_bug.cgi?id=118759

Attachment 206877: Patch
https://bugs.webkit.org/attachment.cgi?id=206877&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206877&action=review


> Source/WebKit/efl/ewk/ewk_settings.cpp:363
> +    if (s_offlineAppCachePath)

We call this API in _ewk_init_body() by defalut. Thus, can't application change
this path using this API ? It seems to me this API needs to be internal
function or removed.