[webkit-reviews] review requested: [Bug 123131] Re-instate ProposedDatabases needed by detailsForNameAndOrigin() : [Attachment 214937] patch 2: added a test, and track only 1 ProposedDatabase in DatabaseManager.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 23 01:09:11 PDT 2013


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 123131: Re-instate ProposedDatabases needed by detailsForNameAndOrigin()
https://bugs.webkit.org/show_bug.cgi?id=123131

Attachment 214937: patch 2: added a test, and track only 1 ProposedDatabase in
DatabaseManager.
https://bugs.webkit.org/attachment.cgi?id=214937&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
I tried to update the DumpRenderTree and test runner files for all the ports
needed for the new test, but the gtk one has an abstraction layer that I don't
quite understand yet.  So, instead, I added a TestExpectation to fail the test
for the gtk port.  The gtk port owners will have to implement the needed
changes based on other ports.

The test changes have been tested on Mac.  Will need to let the EWS check if
they build on the other ports.


More information about the webkit-reviews mailing list