[webkit-reviews] review granted: [Bug 123130] Remote Layer Tree: Implement superlayer, removeFromSuperlayer, replaceSublayer, and adoptSublayers : [Attachment 214876] we'll assert that they're PlatformCALayerRemotes in just one place

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 22 17:55:48 PDT 2013


Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 123130: Remote Layer Tree: Implement superlayer, removeFromSuperlayer,
replaceSublayer, and adoptSublayers
https://bugs.webkit.org/show_bug.cgi?id=123130

Attachment 214876: we'll assert that they're PlatformCALayerRemotes in just one
place
https://bugs.webkit.org/attachment.cgi?id=214876&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214876&action=review


> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:154
> +    PlatformCALayerList& siblings = m_children;

I don't think you need to use this local variable. Also, it is misnamed.


More information about the webkit-reviews mailing list