[webkit-reviews] review granted: [Bug 122848] Adding Mock class to test RTCPeerConnection : [Attachment 214873] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 122848: Adding Mock class to test RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=122848

Attachment 214873: Patch
https://bugs.webkit.org/attachment.cgi?id=214873&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214873&action=review


> Source/WebCore/ChangeLog:28
> +	   * platform/mock/RTCMockNotifiers.cpp: Added.
> +	   * platform/mock/RTCMockNotifiers.h: Added.

Sorry for just noticing this, but "RTCNotifiersMock" would probably be a better
name than "RTCMockNotifiers".

> Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.h:37
> +class RTCPeerConnectionHandlerMock : public RTCPeerConnectionHandler, public
TimerEventBasedMock {

This can be FINAL (I should have also noticed this as well).