[webkit-reviews] review granted: [Bug 123138] Add a cross-platform IDBRecordIdentifier : [Attachment 214866] Patch v2

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 123138: Add a cross-platform IDBRecordIdentifier
https://bugs.webkit.org/show_bug.cgi?id=123138

Attachment 214866: Patch v2 
https://bugs.webkit.org/attachment.cgi?id=214866&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214866&action=review


Okay. r=me

Looking forward to your "fix all of this terrible code" refactor :)

> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:1643
> +    virtual const IDBRecordIdentifier& recordIdentifier() const OVERRIDE {
ASSERT_NOT_REACHED(); return *(m_recordIdentifier.get()); }

return *m_recordIdentifier;

> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:1734
> +    virtual const IDBRecordIdentifier& recordIdentifier() const OVERRIDE {
ASSERT_NOT_REACHED(); return *(m_recordIdentifier.get()); }

return *m_recordIdentifier;

> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:117
> +	   virtual const IDBRecordIdentifier& recordIdentifier() const OVERRIDE
{ return *(m_recordIdentifier.get()); }

return *m_recordIdentifier;