[webkit-reviews] review granted: [Bug 123139] Remote Layer Tree: Support hardware accelerated filters : [Attachment 214823] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 123139: Remote Layer Tree: Support hardware accelerated filters
https://bugs.webkit.org/show_bug.cgi?id=123139

Attachment 214823: patch
https://bugs.webkit.org/attachment.cgi?id=214823&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214823&action=review


> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1183
> +static void encodeFilterOperation(ArgumentEncoder& encoder, FilterOperation*
filter)

I think FilterOperation should be a const reference.

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1318
> +	   filters.operations().append(filter);

Can use std::move(filter) here to avoid ref churn.