[webkit-reviews] review denied: [Bug 123160] HTML input type objects should be managed through std::unique_ptr : [Attachment 214852] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 123160: HTML input type objects should be managed through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=123160

Attachment 214852: Patch
https://bugs.webkit.org/attachment.cgi?id=214852&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214852&action=review


> Source/WebCore/html/ButtonInputType.cpp:40
> -    return adoptPtr(new ButtonInputType(element));
> +    return std::unique_ptr<ButtonInputType>(new ButtonInputType(element));

instead of this pattern, you should just use std::make_unique. Get rid of the
create functions and make the constructors public instead.