[webkit-reviews] review granted: [Bug 122489] [Media] Refactor supportsType() factory method to take a parameters object. : [Attachment 213686] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 122489: [Media] Refactor supportsType() factory method to take a parameters
object.
https://bugs.webkit.org/show_bug.cgi?id=122489

Attachment 213686: Patch
https://bugs.webkit.org/attachment.cgi?id=213686&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213686&action=review


> Source/WebCore/platform/graphics/MediaPlayer.cpp:405
> +    parameters.isMediaSource = !!m_mediaSource;

We will want to use this for other features  (eg. MediaStream), so an enum
would be better than a Boolean here.