[webkit-reviews] review granted: [Bug 123136] [Cocoa] Add load delegate method for didChangeBackForwardList : [Attachment 214817] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 21 22:14:53 PDT 2013


Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 123136: [Cocoa] Add load delegate method for didChangeBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=123136

Attachment 214817: Patch
https://bugs.webkit.org/attachment.cgi?id=214817&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214817&action=review


> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:496
> +    if ([browsingContext.loadDelegate
respondsToSelector:@selector(browsingContextControllerDidChangedBackForwardList
:addedItem:removedItems:)]) {

I think this would look better with an early return (unless this is the
parttern we're using elsewhere).


More information about the webkit-reviews mailing list