[webkit-reviews] review denied: [Bug 85121] Implement reverse animation direction on Windows CoreAnimation : [Attachment 214800] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 21 17:42:33 PDT 2013
Dean Jackson <dino at apple.com> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 85121: Implement reverse animation direction on Windows CoreAnimation
https://bugs.webkit.org/show_bug.cgi?id=85121
Attachment 214800: Patch
https://bugs.webkit.org/attachment.cgi?id=214800&action=review
------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214800&action=review
> Source/WebCore/platform/animation/TimingFunction.h:145
> + return adoptRef(new CubicBezierTimingFunction(Ease, 1.0 - m_x2, 1.0
- m_y2, 1.0 - m_x1, 1.0 - m_y1));
As discussed on IRC...
BTW - why not return CubicBezierTimingFunction::create(new points); ?
More information about the webkit-reviews
mailing list