[webkit-reviews] review granted: [Bug 123052] [iOS] Upstream ARMv7{f, s} bits : [Attachment 214621] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 123052: [iOS] Upstream ARMv7{f, s} bits
https://bugs.webkit.org/show_bug.cgi?id=123052

Attachment 214621: Patch
https://bugs.webkit.org/attachment.cgi?id=214621&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214621&action=review


r=me

> Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:44
>  CLANG_ENABLE_OBJC_ARC = $(CLANG_ENABLE_OBJC_ARC_$(CURRENT_ARCH));
> +CLANG_ENABLE_OBJC_ARC_i386 = YES;
>  CLANG_ENABLE_OBJC_ARC_x86_64 = YES;
>  CLANG_ENABLE_OBJC_ARC_arm64 = YES;
>  CLANG_ENABLE_OBJC_ARC_armv7 = YES;

This has armv7s (out of context), should it also have armv7f?