[webkit-reviews] review granted: [Bug 122146] Grammar markers are not updated when switching between 1x and 2x : [Attachment 214532] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 21 13:32:19 PDT 2013


Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 122146: Grammar markers are not updated when switching between 1x and 2x
https://bugs.webkit.org/show_bug.cgi?id=122146

Attachment 214532: Patch
https://bugs.webkit.org/attachment.cgi?id=214532&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214532&action=review


> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:641
> +    // Unnecessary, since our document markers don't use resources

Nit: period needed at end of comment.

> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:108
> +    // Be lazy.

I'm not sure what this means.

> Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:187
> +    // Unnecessary, since our document markers don't use resources

Nit: period.


More information about the webkit-reviews mailing list