[webkit-reviews] review granted: [Bug 123105] Transition most use of IDBBackingStoreLevelDB to IDBBackingStoreInterface : [Attachment 214766] Patch v4 - Trying this again...
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 21 13:15:20 PDT 2013
Anders Carlsson <andersca at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 123105: Transition most use of IDBBackingStoreLevelDB to
IDBBackingStoreInterface
https://bugs.webkit.org/show_bug.cgi?id=123105
Attachment 214766: Patch v4 - Trying this again...
https://bugs.webkit.org/attachment.cgi?id=214766&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214766&action=review
> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:70
> + virtual bool getIDBDatabaseMetaData(const String& name,
IDBDatabaseMetadata*, bool& success) OVERRIDE FINAL WARN_UNUSED_RETURN;
Instead of making all these FINAL you can just make the class itself final.
More information about the webkit-reviews
mailing list