[webkit-reviews] review granted: [Bug 123084] Avoid JSC debugger overhead unless needed : [Attachment 214756] patch 3: fixed style issues.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 123084: Avoid JSC debugger overhead unless needed
https://bugs.webkit.org/show_bug.cgi?id=123084

Attachment 214756: patch 3: fixed style issues.
https://bugs.webkit.org/attachment.cgi?id=214756&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214756&action=review


r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   - Fixed a bug with ScriptDebugServer::m_currentCallFrame getting
stale.

Your ChangeLog needs to explain what this bug was, how you fixed it, and what
it's tested by.

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:261
> +    setNeedsExceptionCallbacks(pause != DontPauseOnExceptions);

The default Web Inspector condition is to require callbacks for uncaught
exceptions, but not for caught exceptions. It's not very interesting to have a
debugger feature for when no exception callbacks are required at all, since
that condition is false by default. It would be more interesting to have a
debugger feature for when only uncaught exception callbacks are required.