[webkit-reviews] review denied: [Bug 119979] REGRESSION(r127163): Respect clearance set on ancestors when placing floats : [Attachment 214749] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 119979: REGRESSION(r127163): Respect clearance set on ancestors when
placing floats
https://bugs.webkit.org/show_bug.cgi?id=119979

Attachment 214749: Patch
https://bugs.webkit.org/attachment.cgi?id=214749&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214749&action=review


> Source/WebCore/rendering/RenderBlockFlow.cpp:821
> -	       if (!marginInfo.canCollapseWithMarginBefore())
> +	       if (!marginInfo.canCollapseWithMarginBefore() ||
(marginInfo.atBeforeSideOfBlock() && style()->clear() && getClearDelta(this,
logicalTop)))

Minusing for this bit. collapseMargins is computing the logical top prior to
clearance, so checking for clearance inside collapseMargins is a no-no. (Look
at the call site of collapseMargins.)