[webkit-reviews] review granted: [Bug 123041] Limit use of display sleep assertion when <video> element is off-screen. : [Attachment 214624] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 123041: Limit use of display sleep assertion when <video> element is
off-screen.
https://bugs.webkit.org/show_bug.cgi?id=123041

Attachment 214624: Patch
https://bugs.webkit.org/attachment.cgi?id=214624&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214624&action=review


> Source/WebCore/dom/Document.cpp:1544
> +    for (auto i = m_pageVisibilityStateCallbackElements.begin(); i != end;
++i)

We normally use “it” rather than “i” when it’s an iterator instead of an index.


> Source/WebCore/html/HTMLMediaElement.cpp:349
>      document.registerForPrivateBrowsingStateChangedCallbacks(this);
> +#if ENABLE(PAGE_VISIBILITY_API)
> +    document.registerForPageVisibilityStateCallbacks(this);
> +#endif

I’d prefer to see a blank line before this.

> Source/WebCore/html/HTMLMediaElement.cpp:378
>      document().unregisterForPrivateBrowsingStateChangedCallbacks(this);
> +#if ENABLE(PAGE_VISIBILITY_API)
> +    document().unregisterForPageVisibilityStateCallbacks(this);
> +#endif

I’d prefer to see a blank line before this.