[webkit-reviews] review granted: [Bug 123013] Bad cast with toRenderBoxModelObject in RenderBlock::updateFirstLetter() : [Attachment 214718] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 21 02:32:54 PDT 2013


Andreas Kling <akling at apple.com> has granted Joone Hur <joone at webkit.org>'s
request for review:
Bug 123013: Bad cast with toRenderBoxModelObject in
RenderBlock::updateFirstLetter()
https://bugs.webkit.org/show_bug.cgi?id=123013

Attachment 214718: Patch
https://bugs.webkit.org/attachment.cgi?id=214718&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214718&action=review


Ok, r=me.

> Source/WebCore/rendering/RenderBlock.cpp:5183
> +		       createFirstLetterRenderer(firstLetterBlock,
toRenderText(remainingText));

You don't need the toRenderText() here.


More information about the webkit-reviews mailing list