[webkit-reviews] review denied: [Bug 115152] [EFL][WK2] Add APIs to set/get the text zoom factor. : [Attachment 199627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 20 22:28:34 PDT 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Jaehun Lim
<ljaehun.lim at samsung.com>'s request for review:
Bug 115152: [EFL][WK2] Add APIs to set/get the text zoom factor.
https://bugs.webkit.org/show_bug.cgi?id=115152

Attachment 199627: Patch
https://bugs.webkit.org/attachment.cgi?id=199627&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199627&action=review


Set r-

>> Source/WebKit2/UIProcess/API/efl/ewk_view.h:864
>> +EAPI Eina_Bool ewk_view_text_zoom_factor_set(Evas_Object* ewkView, double
zoomFactor);
> 
> Star on wrong side. First parameter should be called "o"

And also, s/zoomFactor/zoom_factor/g


More information about the webkit-reviews mailing list