[webkit-reviews] review granted: [Bug 123083] Use PassRef for StyleSheetContents. : [Attachment 214700] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 20 08:19:05 PDT 2013
Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 123083: Use PassRef for StyleSheetContents.
https://bugs.webkit.org/show_bug.cgi?id=123083
Attachment 214700: Patch v2
https://bugs.webkit.org/attachment.cgi?id=214700&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=214700&action=review
> Source/WebCore/css/CSSStyleSheet.h:51
> - static PassRefPtr<CSSStyleSheet> create(PassRefPtr<StyleSheetContents>,
CSSImportRule* ownerRule = 0);
> - static PassRefPtr<CSSStyleSheet> create(PassRefPtr<StyleSheetContents>,
Node* ownerNode);
> + static PassRefPtr<CSSStyleSheet> create(PassRef<StyleSheetContents>,
CSSImportRule* ownerRule = 0);
> + static PassRefPtr<CSSStyleSheet> create(PassRef<StyleSheetContents>,
Node* ownerNode);
Why not PassRef return?
> Source/WebCore/css/CSSStyleSheet.h:114
> - StyleSheetContents* contents() const { return m_contents.get(); }
> + StyleSheetContents* contents() { return &m_contents.get(); }
Reference?
More information about the webkit-reviews
mailing list