[webkit-reviews] review granted: [Bug 122939] Baseline JIT and DFG IC code generation should be unified and rationalized : [Attachment 214666] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 122939: Baseline JIT and DFG IC code generation should be unified and
rationalized
https://bugs.webkit.org/show_bug.cgi?id=122939

Attachment 214666: the patch
https://bugs.webkit.org/attachment.cgi?id=214666&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214666&action=review


r=me

> Source/JavaScriptCore/bytecode/CodeBlock.h:150
>      bool isStrictMode() const { return m_isStrictMode; }
> +    ECMAMode ecmaMode() const { return isStrictMode() ? StrictMode :
NotStrictMode; }

Can we just change m_isStrictMode to m_ecmaMode?

> Source/JavaScriptCore/dfg/DFGInlineCacheWrapper.h:49
> +    GeneratorType m_gen;

m_generator?

> Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:229
> +    for (unsigned i = m_getByIds.size(); i--;)
> +	   m_getByIds[i].finalize(linkBuffer);
> +    for (unsigned i = m_putByIds.size(); i--;)
> +	   m_putByIds[i].finalize(linkBuffer);

So. Much. Better.

> Source/JavaScriptCore/jit/AssemblyHelpers.h:369
> +    ECMAMode strictModeFor(CodeOrigin codeOrigin)

ecmaModeFor?