[webkit-reviews] review granted: [Bug 122848] Adding Mock class to test RTCPeerConnection : [Attachment 214471] Refactored patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 122848: Adding Mock class to test RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=122848

Attachment 214471: Refactored patch
https://bugs.webkit.org/attachment.cgi?id=214471&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214471&action=review


> Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.h:49
> +    virtual PassRefPtr<RTCSessionDescriptionDescriptor> localDescription()
OVERRIDE;
> +    virtual PassRefPtr<RTCSessionDescriptionDescriptor> remoteDescription()
OVERRIDE;

PassRefPtrs are no longer needed for return values because Anders added
move-semantics to the RefPtr class. You can return RefPtr here.