[webkit-reviews] review granted: [Bug 123043] Remote Layer Tree: Double-buffering and minimization of repaints : [Attachment 214622] revised

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 18 17:45:55 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 123043: Remote Layer Tree: Double-buffering and minimization of repaints
https://bugs.webkit.org/show_bug.cgi?id=123043

Attachment 214622: revised
https://bugs.webkit.org/attachment.cgi?id=214622&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214622&action=review


> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:99
> +	   setNeedsDisplay();

It's odd to call setNeedsDisplay() inside of display().

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:108
> +	   setNeedsDisplay(indicatorRect);

Ditto.


More information about the webkit-reviews mailing list