[webkit-reviews] review granted: [Bug 121661] Frequent RELEASE_ASSERT crashes in Structure::checkOffsetConsistency on WebGL swizzler tests : [Attachment 214587] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 121661: Frequent RELEASE_ASSERT crashes in
Structure::checkOffsetConsistency on WebGL swizzler tests
https://bugs.webkit.org/show_bug.cgi?id=121661

Attachment 214587: the patch
https://bugs.webkit.org/attachment.cgi?id=214587&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214587&action=review


r=me

> Source/JavaScriptCore/ChangeLog:21
> +	   keeping in sync with m_offset, we have the checkOffsetConsistency
method. It's meant to be

it in sync

> Source/JavaScriptCore/ChangeLog:39
> +	   outOfLineCapacity(), and is right to do wo without holding any locks
(since in all cases where

do so

> Source/JavaScriptCore/ChangeLog:44
> +	   property table modified - instead what happens is that so downstream
structure steals the

some downstream