[webkit-reviews] review granted: [Bug 106864] [EFL][WK2] Process single tap using mouse move, down and up event. : [Attachment 214552] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 18 07:00:13 PDT 2013


Christophe Dumez <dchris at gmail.com> has granted EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 106864: [EFL][WK2] Process single tap using mouse move, down and up event.
https://bugs.webkit.org/show_bug.cgi?id=106864

Attachment 214552: Patch
https://bugs.webkit.org/attachment.cgi?id=214552&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214552&action=review


LGTM % the mouse move which seems a little bit odd. r=me.

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:142
> +    WKViewSendMouseMoveEvent(m_ewkView->wkView(), &mouseMove);

So we need to send a MouseMoveEvent for a single tap? Mouse down then up is not
enough?


More information about the webkit-reviews mailing list