[webkit-reviews] review granted: [Bug 120160] [GTK] Add WebKit2 API for TLS errors : [Attachment 214258] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Brian Holt
<brian.holt at samsung.com>'s request for review:
Bug 120160: [GTK] Add WebKit2 API for TLS errors
https://bugs.webkit.org/show_bug.cgi?id=120160

Attachment 214258: Patch
https://bugs.webkit.org/attachment.cgi?id=214258&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214258&action=review


> Source/WebCore/platform/network/CertificateInfo.h:47
> +    explicit CertificateInfo(GTlsCertificateFlags, GTlsCertificate*);

I think it would be better to pass the certificate as a first argument instead.
That way if we eventually use the CertificateInfo to wrap a certificate with no
tls errors, we could make the flags argument optional by giving it a default
value of 0 (which means no errors)

> Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:28
> +    _WebKitCertificateInfo(GTlsCertificateFlags tlsErrors, GTlsCertificate*
certificate)

And we might change the order here too

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:861
> +	*

We should also document here what happens when the user returns TRUE/FALSE
(load finishes/load-failed is emitted and load finishes)