[webkit-reviews] review denied: [Bug 122175] use adoptCOM template instead of COMPtr::adoptRef : [Attachment 214528] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 17 16:14:56 PDT 2013


Alex Christensen <alex.christensen at flexsim.com> has denied Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 122175: use adoptCOM template instead of COMPtr::adoptRef
https://bugs.webkit.org/show_bug.cgi?id=122175

Attachment 214528: Patch
https://bugs.webkit.org/attachment.cgi?id=214528&action=review

------- Additional Comments from Alex Christensen
<alex.christensen at flexsim.com>
Some of these should be left as they are.  adoptCOM should only replace
adoptRef when the COMPtr is declared and the next line is calling adoptRef. 
Otherwise it changes functionality.


More information about the webkit-reviews mailing list