[webkit-reviews] review granted: [Bug 122897] Web Inspector: logged objects are highlighted in blue : [Attachment 214501] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 17 13:59:44 PDT 2013
Joseph Pecoraro <joepeck at webkit.org> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 122897: Web Inspector: logged objects are highlighted in blue
https://bugs.webkit.org/show_bug.cgi?id=122897
Attachment 214501: Patch
https://bugs.webkit.org/attachment.cgi?id=214501&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214501&action=review
r=me
So we'll now get the light highlight everywhere? Does it look good everywhere?
I think it'll be good, it'll especially be an improvement for DOMNode / Object
interaction.
>
Source/WebInspectorUI/UserInterface/Images/UserInputPromptPreviousSelected.svg:
-1
> -<?xml version="1.0" encoding="utf-8"?>
Could you also remove these sag files from the Visual Studio project files?
Lame, I know. But we don't need to be proactive adding files, just removing
them =).
shell> ack -a UserInputPromptPreviousSelected.svg
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj
539: <None
Include="..\UserInterface\Images\UserInputPromptPreviousSelected.svg" />
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters
1698: <None
Include="..\UserInterface\Images\UserInputPromptPreviousSelected.svg">
More information about the webkit-reviews
mailing list