[webkit-reviews] review granted: [Bug 122987] Fix three bugs in the equals() implementations for css gradients. : [Attachment 214492] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Nico Weber <thakis at chromium.org>'s
request for review:
Bug 122987: Fix three bugs in the equals() implementations for css gradients.
https://bugs.webkit.org/show_bug.cgi?id=122987

Attachment 214492: Patch
https://bugs.webkit.org/attachment.cgi?id=214492&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214492&action=review


r=me, but..

> Source/WebCore/css/CSSGradientValue.cpp:737
>      else
> -	   equalXorY = !other.m_firstX || !other.m_firstY;
> +	   equalXandY = !other.m_firstX && !other.m_firstY;

Don't we already know that both firstX and firstY are null at this point?

> Source/WebCore/css/CSSGradientValue.cpp:1149
>      else
> -	   equalXorY == !other.m_firstX || !other.m_firstY;
> +	   equalXandY = !other.m_firstX && !other.m_firstY;

And here?