[webkit-reviews] review granted: [Bug 122146] Grammar markers are not updated when switching between 1x and 2x : [Attachment 214283] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 122146: Grammar markers are not updated when switching between 1x and 2x
https://bugs.webkit.org/show_bug.cgi?id=122146

Attachment 214283: Patch
https://bugs.webkit.org/attachment.cgi?id=214283&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214283&action=review


Have you measured the perf cost of re-creating the NSColor every time?

> Source/WebCore/ChangeLog:16
> +	   want to recreate the NSColor whenever the device pixel ratio
chagnes.

chagnes