[webkit-reviews] review denied: [Bug 122781] Refactor stored website data APIs : [Attachment 214395] typo in GNUmakefile.list.am

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied  review:
Bug 122781: Refactor stored website data APIs
https://bugs.webkit.org/show_bug.cgi?id=122781

Attachment 214395: typo in GNUmakefile.list.am
https://bugs.webkit.org/attachment.cgi?id=214395&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214395&action=review


Looks good overall.  One thing that gets an r- from me, but should be easy to
address.

> Source/WebKit2/UIProcess/API/C/WKOriginDataManager.h:46
> +typedef uint32_t WKOriginDataTypes;

Since we never really store these and aren't concerned about memory usage/etc,
and since we'd like to make this one API as future proof as possible, let's
make this a uint64_t here and everywhere else that uses it.

Otherwise we'd be cursing ourselves when we add the 33rd data type...

> Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:85
> +void WebOriginDataManager::deleteEntriesForOrigin(WKOriginDataTypes types,
const SecurityOriginData& originData)
> +{
> +    RefPtr<SecurityOrigin> origin =
SecurityOrigin::create(originData.protocol, originData.host, originData.port);
> +    if (!origin)
> +	   return;
> +
> +    // FIXME: delete cache

Not really "delete cache", it's more than that!