[webkit-reviews] review requested: [Bug 122931] Transition cti_op_throw and cti_vm_throw to a JIT operation : [Attachment 214468] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 17 10:24:26 PDT 2013


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 122931: Transition cti_op_throw and cti_vm_throw to a JIT operation
https://bugs.webkit.org/show_bug.cgi?id=122931

Attachment 214468: Updated patch
https://bugs.webkit.org/attachment.cgi?id=214468&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
(In reply to comment #2)
> (From update of attachment 214424 [details])
> Why doesn't this just have the code for op_throw call operationDoThrow
directly and then perform the jump from JIT code?  Seems like that would be an
easier design.

Made this suggested change.

Also, since all cti_stubs that had exception checks before returning have been
eliminated, I removed cti_vm_throw and it's caller ctiVMThrowTrampoline().


More information about the webkit-reviews mailing list